Fix add plugin unit test #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| assert.deepEqual(actualDependencies, expectedDependencies); | ||
| let expectedDependencies = { "plugin1": "^1.0.3" }; | ||
| let expectedDependenciesExact = { "plugin1": "1.0.3" }; | ||
| assert.isTrue(_.isEqual(actualDependencies, expectedDependencies) || _.isEqual(actualDependencies, expectedDependenciesExact)); |
There was a problem hiding this comment.
_.isEqual compares deeply
There was a problem hiding this comment.
so we consider both syntax are correct (^1.0.3 and 1.0.3) ?
There was a problem hiding this comment.
Yes, I have updated PR description.
|
👍 after rebasing on master |
teobugslayer
force-pushed
the
totev/fix-plugin-check-ver
branch
from
09c560b to
b14d4b7
Compare
|
✅ |
|
|
||
| let commandsService = testInjector.resolve(CommandsServiceLib.CommandsService); | ||
| commandsService.tryExecuteCommand("plugin|add", [pluginName+"@1.0.0"]).wait(); | ||
| pluginsService.add(pluginName+"@1.0.0").wait(); |
There was a problem hiding this comment.
or maybe ${pluginName}@1.0.0
There was a problem hiding this comment.
We agreed to leave the code as is.
Small code cleanups
teobugslayer
force-pushed
the
totev/fix-plugin-check-ver
branch
from
b14d4b7 to
07bf8d9
Compare
|
✅ |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Npm has a global configuration to save dependencies with exact versions or as ^ ones. This unit test must work in both configurations. Therefore, we check for one of the two possible outcomes.
Also, small code cleanups.